diff --git a/common/server.h b/common/server.h index 810886226..896f6ef8e 100644 --- a/common/server.h +++ b/common/server.h @@ -60,8 +60,11 @@ public: virtual int getMaxMessageCountPerInterval() const { return 0; } virtual int getMaxMessageSizePerInterval() const { return 0; } virtual int getMaxGamesPerUser() const { return 0; } + virtual int getCommandCountingInterval() const { return 0; } + virtual int getMaxCommandCountPerInterval() const { return 0; } + virtual bool getThreaded() const { return false; } - + Server_DatabaseInterface *getDatabaseInterface() const; int getNextLocalGameId() { QMutexLocker locker(&nextLocalGameIdMutex); return ++nextLocalGameId; } diff --git a/common/server_protocolhandler.cpp b/common/server_protocolhandler.cpp index 07f3fd0ff..a7ec3ade6 100644 --- a/common/server_protocolhandler.cpp +++ b/common/server_protocolhandler.cpp @@ -217,12 +217,26 @@ Response::ResponseCode Server_ProtocolHandler::processGameCommandContainer(const if (!player) return Response::RespNotInRoom; + int commandCountingInterval = server->getCommandCountingInterval(); + int maxMessageCountPerInterval = server->getMaxMessageCountPerInterval(); GameEventStorage ges; Response::ResponseCode finalResponseCode = Response::RespOk; for (int i = cont.game_command_size() - 1; i >= 0; --i) { const GameCommand &sc = cont.game_command(i); logDebugMessage(QString("game %1 player %2: ").arg(cont.game_id()).arg(roomIdAndPlayerId.second) + QString::fromStdString(sc.ShortDebugString())); - + + if (commandCountingInterval > 0) { + int totalCount = 0; + if (commandCountOverTime.isEmpty()) + commandCountOverTime.prepend(0); + ++commandCountOverTime[0]; + for (int i = 0; i < commandCountOverTime.size(); ++i) + totalCount += commandCountOverTime[i]; + + if (totalCount > maxMessageCountPerInterval) + return Response::RespChatFlood; + } + Response::ResponseCode resp = player->processGameCommand(sc, rc, ges); if (resp != Response::RespOk) @@ -314,7 +328,14 @@ void Server_ProtocolHandler::pingClockTimeout() if (messageCountOverTime.size() > server->getMessageCountingInterval()) messageCountOverTime.removeLast(); } - + + interval = server->getCommandCountingInterval(); + if (interval > 0) { + commandCountOverTime.prepend(0); + if (commandCountOverTime.size() > server->getCommandCountingInterval()) + commandCountOverTime.removeLast(); + } + if (timeRunning - lastDataReceived > server->getMaxPlayerInactivityTime()) prepareDestroy(); ++timeRunning; diff --git a/common/server_protocolhandler.h b/common/server_protocolhandler.h index 98e0f6cc2..5389b724e 100644 --- a/common/server_protocolhandler.h +++ b/common/server_protocolhandler.h @@ -51,7 +51,7 @@ protected: bool acceptsRoomListChanges; virtual void logDebugMessage(const QString & /* message */) { } private: - QList messageSizeOverTime, messageCountOverTime; + QList messageSizeOverTime, messageCountOverTime, commandCountOverTime; int timeRunning, lastDataReceived; QTimer *pingClock; diff --git a/servatrice/servatrice.ini.example b/servatrice/servatrice.ini.example index c44547450..52c1f61b3 100644 --- a/servatrice/servatrice.ini.example +++ b/servatrice/servatrice.ini.example @@ -130,7 +130,7 @@ max_users_per_address=4 ; IP addresses listed (ignoring the max_users_per_address). Default is "127.0.0.1,::1"; example: "192.73.233.244,81.4.100.74" trusted_sources="127.0.0.1,::1" -; Servatrice can avoid users from flooding rooms with large number messages in an interval of time. +; Servatrice can avoid users from flooding rooms with large number of messages in an interval of time. ; This setting defines the length in seconds of the considered interval; default is 10 message_counting_interval=10 @@ -143,6 +143,12 @@ max_message_count_per_interval=10 ; Maximum number of games a single user can create; default is 5 max_games_per_user=5 +; Servatrice can avoid users from flooding games with large number of game commands in an interval of time. +; This setting defines the length in seconds of the considered interval; default is 10 +command_counting_interval=10 + +; Maximum number of game commands in an interval before new commands gets dropped; default is 10 +max_command_count_per_interval=10 [logging] diff --git a/servatrice/src/servatrice.cpp b/servatrice/src/servatrice.cpp index b2c957b3a..2e730a22e 100644 --- a/servatrice/src/servatrice.cpp +++ b/servatrice/src/servatrice.cpp @@ -259,6 +259,8 @@ bool Servatrice::initServer() maxMessageCountPerInterval = settingsCache->value("security/max_message_count_per_interval", 10).toInt(); maxMessageSizePerInterval = settingsCache->value("security/max_message_size_per_interval", 1000).toInt(); maxGamesPerUser = settingsCache->value("security/max_games_per_user", 5).toInt(); + commandCountingInterval = settingsCache->value("game/command_counting_interval", 10).toInt(); + maxCommandCountPerInterval = settingsCache->value("game/max_command_count_per_interval", 10).toInt(); try { if (settingsCache->value("servernetwork/active", 0).toInt()) { qDebug() << "Connecting to ISL network."; diff --git a/servatrice/src/servatrice.h b/servatrice/src/servatrice.h index baa2e6e89..e7e548d14 100644 --- a/servatrice/src/servatrice.h +++ b/servatrice/src/servatrice.h @@ -115,8 +115,8 @@ private: QMutex txBytesMutex, rxBytesMutex; quint64 txBytes, rxBytes; int maxGameInactivityTime, maxPlayerInactivityTime; - int maxUsersPerAddress, messageCountingInterval, maxMessageCountPerInterval, maxMessageSizePerInterval, maxGamesPerUser; - + int maxUsersPerAddress, messageCountingInterval, maxMessageCountPerInterval, maxMessageSizePerInterval, maxGamesPerUser, commandCountingInterval, maxCommandCountPerInterval; + QString shutdownReason; int shutdownMinutes; QTimer *shutdownTimer; @@ -143,6 +143,8 @@ public: int getMaxMessageCountPerInterval() const { return maxMessageCountPerInterval; } int getMaxMessageSizePerInterval() const { return maxMessageSizePerInterval; } int getMaxGamesPerUser() const { return maxGamesPerUser; } + int getCommandCountingInterval() const { return commandCountingInterval; } + int getMaxCommandCountPerInterval() const { return maxCommandCountPerInterval; } AuthenticationMethod getAuthenticationMethod() const { return authenticationMethod; } QString getDbPrefix() const { return dbPrefix; } int getServerId() const { return serverId; }