From db0b1ffe4e976a5b18bcf9e6d7862756b8d0835d Mon Sep 17 00:00:00 2001 From: Paul Holt Date: Sun, 16 Jan 2022 01:48:34 +1100 Subject: [PATCH 1/6] Add bug descriptions discovered by Jack Boyce in Super Star Trek to the main game description. --- 84_Super_Star_Trek/README.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/84_Super_Star_Trek/README.md b/84_Super_Star_Trek/README.md index 77fae3d8..28bd3c03 100644 --- a/84_Super_Star_Trek/README.md +++ b/84_Super_Star_Trek/README.md @@ -88,6 +88,17 @@ The relation between the Historical and Standard nomenclatures is shown in the s 15. This version of Star Trek was created for a Data General Nova 800 system with 32K or core. So that it would fit, the instructions are separated from the main program via a CHAIN. For conversion to DEC BASIC-PLUS, Statement 160 (Randomize) should be moved after the return from the chained instructions, say to Statement 245. For Altair BASIC, Randomize and the chain instructions should be eliminated. +--- +#### Bugs + +Many of the programs in this book and this collection have bugs in the original code. + +Jack Boyce has discovered and fixed a number of bugs in his [python implementation](python/superstartrek.py), which should be noted by other implementers: + +- line `4410` : `D(7)` should be `D(6)` +- lines `8310`,`8330`,`8430`,`8450` : Division by zero is possible +- line `440` : `B9` should be initialised to 0, not 2 + --- As published in Basic Computer Games (1978): From 5b1aaadac1c6e929c40892394832e0f8bf44ee92 Mon Sep 17 00:00:00 2001 From: Paul Holt Date: Sun, 16 Jan 2022 12:30:34 +1100 Subject: [PATCH 2/6] Update with link to give credit where it is due, @jkboyce --- 84_Super_Star_Trek/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/84_Super_Star_Trek/README.md b/84_Super_Star_Trek/README.md index 28bd3c03..e47c90b7 100644 --- a/84_Super_Star_Trek/README.md +++ b/84_Super_Star_Trek/README.md @@ -93,7 +93,7 @@ The relation between the Historical and Standard nomenclatures is shown in the s Many of the programs in this book and this collection have bugs in the original code. -Jack Boyce has discovered and fixed a number of bugs in his [python implementation](python/superstartrek.py), which should be noted by other implementers: +@jkboyce has done a great job of discovering and fixing a number of bugs in the [original code](superstartrek.bas), as part of his [python implementation](python/superstartrek.py), which should be noted by other implementers: - line `4410` : `D(7)` should be `D(6)` - lines `8310`,`8330`,`8430`,`8450` : Division by zero is possible From c4f9b15db0f033373aa533969ea9274cd6ad26e0 Mon Sep 17 00:00:00 2001 From: Paul Holt Date: Sun, 16 Jan 2022 13:09:47 +1100 Subject: [PATCH 3/6] Name should have an uppercase class name, and the correct file suffix. --- 63_Name/java/{main.class => Name.java} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename 63_Name/java/{main.class => Name.java} (98%) diff --git a/63_Name/java/main.class b/63_Name/java/Name.java similarity index 98% rename from 63_Name/java/main.class rename to 63_Name/java/Name.java index db01b014..7b67f489 100644 --- a/63_Name/java/main.class +++ b/63_Name/java/Name.java @@ -1,7 +1,7 @@ import java.util.Arrays; import java.util.Scanner; -public class main { +public class Name { public static void printempty() { System.out.println(" "); } From 18574bd155f20af30aa2789520d86526230a7ad1 Mon Sep 17 00:00:00 2001 From: Paul Holt Date: Sun, 16 Jan 2022 13:24:12 +1100 Subject: [PATCH 4/6] Stop ignoring buildJvm and build.gradle files in gitignore! Add build files for some of the new games Basketball java Battle java Craps java Cube java High IQ java Name java --- .gitignore | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 3412076c..64e591f9 100644 --- a/.gitignore +++ b/.gitignore @@ -2,9 +2,8 @@ .vscode/ .gradle/ node_modules/ -buildJvm/ - -build.gradle +buildJvm/bin +buildJvm/*/build/ .classpath .project From 1f018419a74aa836e94437ae48fdf52044fc1ff7 Mon Sep 17 00:00:00 2001 From: Paul Holt Date: Sun, 16 Jan 2022 13:31:53 +1100 Subject: [PATCH 5/6] Second version of number has the wrong file name, and class names clashed. Added buildscript for Number1 --- 66_Number/java/{main.class => Number1.java} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename 66_Number/java/{main.class => Number1.java} (99%) diff --git a/66_Number/java/main.class b/66_Number/java/Number1.java similarity index 99% rename from 66_Number/java/main.class rename to 66_Number/java/Number1.java index c3df4ebf..c1d71bda 100644 --- a/66_Number/java/main.class +++ b/66_Number/java/Number1.java @@ -4,7 +4,7 @@ import java.util.Arrays; import java.util.Random; import java.util.Scanner; -public class Number { +public class Number1 { public static int points = 0; From 7278f607750bec360ede755cfda88f3b4fba8a9d Mon Sep 17 00:00:00 2001 From: Paul Holt Date: Sun, 16 Jan 2022 13:45:52 +1100 Subject: [PATCH 6/6] Change buildscript for two versions of Number --- 66_Number/java/{Number1.java => 1/Number.java} | 2 +- 66_Number/java/{ => 2}/Number.java | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename 66_Number/java/{Number1.java => 1/Number.java} (99%) rename 66_Number/java/{ => 2}/Number.java (100%) diff --git a/66_Number/java/Number1.java b/66_Number/java/1/Number.java similarity index 99% rename from 66_Number/java/Number1.java rename to 66_Number/java/1/Number.java index c1d71bda..c3df4ebf 100644 --- a/66_Number/java/Number1.java +++ b/66_Number/java/1/Number.java @@ -4,7 +4,7 @@ import java.util.Arrays; import java.util.Random; import java.util.Scanner; -public class Number1 { +public class Number { public static int points = 0; diff --git a/66_Number/java/Number.java b/66_Number/java/2/Number.java similarity index 100% rename from 66_Number/java/Number.java rename to 66_Number/java/2/Number.java