gitea-mirror/Cockatrice
1
0
Fork 0
mirror of https://github.com/Cockatrice/Cockatrice.git synced 2025-12-12 15:49:28 -08:00
Code Issues Packages Projects Releases Wiki Activity

Make SettingsManager params const ref (#5405)

Browse Source 
* pass settingsPath by const ref

* pass params by const ref

* cleanup
This commit is contained in:
RickyRister
2025-01-01 21:33:37 -08:00
committed by GitHub
parent f924b04efd
commit bb4214e28a
16 changed files with 25 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cockatrice/src/settings/card_database_settings.cpp
View File

@@ -1,6 +1,6 @@
#include "card_database_settings.h"
CardDatabaseSettings::CardDatabaseSettings(QString settingPath, QObject *parent)
CardDatabaseSettings::CardDatabaseSettings(const QString &settingPath, QObject *parent)
: SettingsManager(settingPath + "cardDatabase.ini", parent)
{
}

2
cockatrice/src/settings/card_database_settings.h
View File

@@ -25,7 +25,7 @@ signals:
public slots:
private:
explicit CardDatabaseSettings(QString settingPath, QObject *parent = nullptr);
explicit CardDatabaseSettings(const QString &settingPath, QObject *parent = nullptr);
CardDatabaseSettings(const CardDatabaseSettings & /*other*/);
};

2
cockatrice/src/settings/card_override_settings.cpp
View File

@@ -1,6 +1,6 @@
#include "card_override_settings.h"
CardOverrideSettings::CardOverrideSettings(QString settingPath, QObject *parent)
CardOverrideSettings::CardOverrideSettings(const QString &settingPath, QObject *parent)
: SettingsManager(settingPath + "cardPreferenceOverrides.ini", parent)
{
}

2
cockatrice/src/settings/card_override_settings.h
View File

@@ -18,7 +18,7 @@ public:
QString getCardPreferenceOverride(const QString &cardName);
private:
explicit CardOverrideSettings(QString settingPath, QObject *parent = nullptr);
explicit CardOverrideSettings(const QString &settingPath, QObject *parent = nullptr);
CardOverrideSettings(const CardOverrideSettings & /*other*/);
};

2
cockatrice/src/settings/game_filters_settings.cpp
View File

@@ -3,7 +3,7 @@
#include <QCryptographicHash>
#include <QTime>
GameFiltersSettings::GameFiltersSettings(QString settingPath, QObject *parent)
GameFiltersSettings::GameFiltersSettings(const QString &settingPath, QObject *parent)
: SettingsManager(settingPath + "gamefilters.ini", parent)
{
}

2
cockatrice/src/settings/game_filters_settings.h
View File

@@ -46,7 +46,7 @@ signals:
public slots:
private:
explicit GameFiltersSettings(QString settingPath, QObject *parent = nullptr);
explicit GameFiltersSettings(const QString &settingPath, QObject *parent = nullptr);
GameFiltersSettings(const GameFiltersSettings & /*other*/);
QString hashGameType(const QString &gameType) const;

2
cockatrice/src/settings/message_settings.cpp
View File

@@ -1,6 +1,6 @@
#include "message_settings.h"
MessageSettings::MessageSettings(QString settingPath, QObject *parent)
MessageSettings::MessageSettings(const QString &settingPath, QObject *parent)
: SettingsManager(settingPath + "messages.ini", parent)
{
}

2
cockatrice/src/settings/message_settings.h
View File

@@ -20,7 +20,7 @@ signals:
public slots:
private:
explicit MessageSettings(QString settingPath, QObject *parent = nullptr);
explicit MessageSettings(const QString &settingPath, QObject *parent = nullptr);
MessageSettings(const MessageSettings & /*other*/);
};

2
cockatrice/src/settings/recents_settings.cpp
View File

@@ -2,7 +2,7 @@
#define MAX_RECENT_DECK_COUNT 10
RecentsSettings::RecentsSettings(QString settingPath, QObject *parent)
RecentsSettings::RecentsSettings(const QString &settingPath, QObject *parent)
: SettingsManager(settingPath + "recents.ini", parent)
{
}

2
cockatrice/src/settings/recents_settings.h
View File

@@ -8,7 +8,7 @@ class RecentsSettings : public SettingsManager
Q_OBJECT
friend class SettingsCache;
explicit RecentsSettings(QString settingPath, QObject *parent = nullptr);
explicit RecentsSettings(const QString &settingPath, QObject *parent = nullptr);
RecentsSettings(const RecentsSettings & /*other*/);
public:

2
cockatrice/src/settings/servers_settings.cpp
View File

@@ -3,7 +3,7 @@
#include <QDebug>
#include <utility>
ServersSettings::ServersSettings(QString settingPath, QObject *parent)
ServersSettings::ServersSettings(const QString &settingPath, QObject *parent)
: SettingsManager(settingPath + "servers.ini", parent)
{
}

2
cockatrice/src/settings/servers_settings.h
View File

@@ -61,7 +61,7 @@ public:
bool getClearDebugLogStatus(bool abDefaultValue);
private:
explicit ServersSettings(QString settingPath, QObject *parent = nullptr);
explicit ServersSettings(const QString &settingPath, QObject *parent = nullptr);
ServersSettings(const ServersSettings & /*other*/);
};

11
cockatrice/src/settings/settings_manager.cpp
View File

@@ -1,11 +1,14 @@
#include "settings_manager.h"
SettingsManager::SettingsManager(QString settingPath, QObject *parent)
SettingsManager::SettingsManager(const QString &settingPath, QObject *parent)
: QObject(parent), settings(settingPath, QSettings::IniFormat)
{
}
void SettingsManager::setValue(QVariant value, QString name, QString group, QString subGroup)
void SettingsManager::setValue(const QVariant &value,
const QString &name,
const QString &group,
const QString &subGroup)
{
if (!group.isEmpty()) {
settings.beginGroup(group);
@@ -26,7 +29,7 @@ void SettingsManager::setValue(QVariant value, QString name, QString group, QStr
}
}
void SettingsManager::deleteValue(QString name, QString group, QString subGroup)
void SettingsManager::deleteValue(const QString &name, const QString &group, const QString &subGroup)
{
if (!group.isEmpty()) {
settings.beginGroup(group);
@@ -47,7 +50,7 @@ void SettingsManager::deleteValue(QString name, QString group, QString subGroup)
}
}
QVariant SettingsManager::getValue(QString name, QString group, QString subGroup)
QVariant SettingsManager::getValue(const QString &name, const QString &group, const QString &subGroup)
{
if (!group.isEmpty()) {
settings.beginGroup(group);

12
cockatrice/src/settings/settings_manager.h
View File

@@ -10,18 +10,14 @@ class SettingsManager : public QObject
{
Q_OBJECT
public:
explicit SettingsManager(QString settingPath, QObject *parent = nullptr);
QVariant getValue(QString name, QString group = "", QString subGroup = "");
explicit SettingsManager(const QString &settingPath, QObject *parent = nullptr);
QVariant getValue(const QString &name, const QString &group = "", const QString &subGroup = "");
void sync();
signals:
public slots:
protected:
QSettings settings;
void setValue(QVariant value, QString name, QString group = "", QString subGroup = "");
void deleteValue(QString name, QString group = "", QString subGroup = "");
void setValue(const QVariant &value, const QString &name, const QString &group = "", const QString &subGroup = "");
void deleteValue(const QString &name, const QString &group = "", const QString &subGroup = "");
};
#endif // SETTINGSMANAGER_H

2
dbconverter/src/mocks.cpp
View File

@@ -1,7 +1,7 @@
#include "mocks.h"
CardDatabaseSettings::CardDatabaseSettings(QString settingPath, QObject *parent)
CardDatabaseSettings::CardDatabaseSettings(const QString &settingPath, QObject *parent)
: SettingsManager(settingPath + "cardDatabase.ini", parent)
{
}

2
tests/carddatabase/mocks.cpp
View File

@@ -1,7 +1,7 @@
#include "mocks.h"
CardDatabaseSettings::CardDatabaseSettings(QString settingPath, QObject *parent)
CardDatabaseSettings::CardDatabaseSettings(const QString &settingPath, QObject *parent)
: SettingsManager(settingPath + "cardDatabase.ini", parent)
{
}