address review comments

This commit is contained in:
Yacine Elhamer
2023-07-10 14:12:56 +01:00
parent af256bc0e9
commit 9394194031
2 changed files with 1 additions and 3 deletions

View File

@@ -45,7 +45,7 @@ def extract_environ_strings(behavior: Dict, ph: ProcessHandle) -> Iterator[Tuple
for variable, value in environ.items():
if value:
yield String(value), NO_ADDRESS
yield String(value), ph.address
def extract_features(behavior: Dict, ph: ProcessHandle) -> Iterator[Tuple[Feature, Address]]:

View File

@@ -167,7 +167,6 @@ class ProcessFeature(HashableModel):
address: the address at which this feature is found.
process != address because, e.g., the feature may be found *within* the scope (process).
versus right at its starting address.
"""
process: Address
@@ -182,7 +181,6 @@ class ThreadFeature(HashableModel):
address: the address at which this feature is found.
thread != address because, e.g., the feature may be found *within* the scope (thread).
versus right at its starting address.
"""
thread: Address