mirror of
https://github.com/mandiant/capa.git
synced 2025-12-12 15:49:46 -08:00
address review comments
This commit is contained in:
@@ -45,7 +45,7 @@ def extract_environ_strings(behavior: Dict, ph: ProcessHandle) -> Iterator[Tuple
|
||||
|
||||
for variable, value in environ.items():
|
||||
if value:
|
||||
yield String(value), NO_ADDRESS
|
||||
yield String(value), ph.address
|
||||
|
||||
|
||||
def extract_features(behavior: Dict, ph: ProcessHandle) -> Iterator[Tuple[Feature, Address]]:
|
||||
|
||||
@@ -167,7 +167,6 @@ class ProcessFeature(HashableModel):
|
||||
address: the address at which this feature is found.
|
||||
|
||||
process != address because, e.g., the feature may be found *within* the scope (process).
|
||||
versus right at its starting address.
|
||||
"""
|
||||
|
||||
process: Address
|
||||
@@ -182,7 +181,6 @@ class ThreadFeature(HashableModel):
|
||||
address: the address at which this feature is found.
|
||||
|
||||
thread != address because, e.g., the feature may be found *within* the scope (thread).
|
||||
versus right at its starting address.
|
||||
"""
|
||||
|
||||
thread: Address
|
||||
|
||||
Reference in New Issue
Block a user