use f-strings as appropriate

closes #600

capa/features/extractors/binja/file.py

@@ -103,7 +103,7 @@ def extract_file_import_names(bv: BinaryView) -> Iterator[Tuple[Feature, Address
 
         ordinal = sym.ordinal
         if ordinal != 0 and (lib_name != ""):
-            ordinal_name = "#%d" % (ordinal)
+            ordinal_name = f"#{ordinal}"
             for name in capa.features.extractors.helpers.generate_symbols(lib_name, ordinal_name):
                 yield Import(name), addr
 
@@ -147,7 +147,7 @@ def extract_file_format(bv: BinaryView) -> Iterator[Tuple[Feature, Address]]:
         # no file type to return when processing a binary file, but we want to continue processing
         return
     else:
-        raise NotImplementedError("unexpected file format: %d" % view_type)
+        raise NotImplementedError(f"unexpected file format: {view_type}")
 
 
 def extract_features(bv: BinaryView) -> Iterator[Tuple[Feature, Address]]:

capa/features/extractors/binja/find_binja_api.py

@@ -26,7 +26,7 @@ if spec is not None:
 
 
 def find_binja_path() -> str:
-    raw_output = subprocess.check_output(["python", "-c", "%s" % code]).decode("ascii").strip()
+    raw_output = subprocess.check_output(["python", "-c", code]).decode("ascii").strip()
     return bytes.fromhex(raw_output).decode("utf8")
 
 

capa/features/insn.py

@@ -70,7 +70,7 @@ class Number(Feature):
         elif isinstance(self.value, float):
             return str(self.value)
         else:
-            raise ValueError("invalid value type %s" % (type(self.value)))
+            raise ValueError(f"invalid value type {type(self.value)}")
 
 
 # max recognized structure size (and therefore, offset size)

capa/main.py

@@ -547,7 +547,7 @@ def get_extractor(
         with halo.Halo(text="analyzing program", spinner="simpleDots", stream=sys.stderr, enabled=not disable_progress):
             bv: BinaryView = BinaryViewType.get_view_of_file(path)
             if bv is None:
-                raise RuntimeError("Binary Ninja cannot open file %s" % (path))
+                raise RuntimeError(f"Binary Ninja cannot open file {path}")
 
         return capa.features.extractors.binja.extractor.BinjaFeatureExtractor(bv)
 
@@ -912,12 +912,12 @@ def install_common_args(parser, wanted=None):
             (OS_MACOS,),
             (OS_WINDOWS,),
         ]
-        os_help = ", ".join(["%s (%s)" % (o[0], o[1]) if len(o) == 2 else o[0] for o in oses])
+        os_help = ", ".join([f"{o[0]} ({o[1]})" if len(o) == 2 else o[0] for o in oses])
         parser.add_argument(
             "--os",
             choices=[o[0] for o in oses],
             default=OS_AUTO,
-            help="select sample OS: %s" % os_help,
+            help=f"select sample OS: {os_help}",
         )
 
     if "rules" in wanted: