mirror of
https://github.com/mandiant/capa.git
synced 2025-12-12 15:49:46 -08:00
incorprate Ana's feedback
This commit is contained in:
21
.github/pull_request_template.md
vendored
21
.github/pull_request_template.md
vendored
@@ -1,29 +1,32 @@
|
||||
<!--
|
||||
# Have you read capa's CONTRIBUTING guide?
|
||||
Thank you for contributing to capa! :heart:
|
||||
|
||||
IMPORTANT NOTE
|
||||
It's most important that you submit your improvements. So even if you don't use this complete template we look forward to collaborating!
|
||||
|
||||
Please read capa's CONTRIBUTING guide if you haven't done so already.
|
||||
It contains helpful information about how to contribute to capa. Check https://github.com/fireeye/capa/blob/master/.github/CONTRIBUTING.md
|
||||
|
||||
based on https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/
|
||||
PR template based on https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/
|
||||
-->
|
||||
|
||||
### Description
|
||||
|
||||
<!-- Please describe the changes in this PR. Including your motivation and context helps us to review. -->
|
||||
|
||||
closes # (issue)
|
||||
|
||||
<!-- Description of the PR -->
|
||||
|
||||
### Type of change
|
||||
|
||||
Please update the [CHANGELOG.md](/CHANGELOG.md)
|
||||
|
||||
- [ ] Bug fix (non-breaking change which fixes an issue)
|
||||
- [ ] New feature (non-breaking change which adds functionality)
|
||||
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
||||
- [ ] This change requires a documentation update
|
||||
- [ ] I have made the corresponding changes to the documentation
|
||||
|
||||
### Tests
|
||||
|
||||
- [ ] I have added tests that prove my fix is effective or that my feature works
|
||||
- [ ] No new tests needed
|
||||
|
||||
### Checklist
|
||||
|
||||
- [ ] I have updated the [CHANGELOG.md](/CHANGELOG.md)
|
||||
- [ ] I have made corresponding changes to the documentation
|
||||
|
||||
Reference in New Issue
Block a user